Ioi Lam comments

Results 38 comments of


                                            Ioi Lam

8295302: Do not use ArrayList when LambdaForm has a single ClassData

Thanks @cl4es @iwanowww @mlchung for the review, and @turbanoff for the suggestion. /integrate

8332176: Refactor ClassListParser::parse()

Thanks @calvinccheung and @matias9927 for the review /integrate

8327651: Rename DictionaryEntry members related to protection domain

Thanks @coleenp @dholmes-ora for the review. /integrate

8330198: Add some class loading related perf counters to measure VM startup

> Okay my first reaction here is "I object!". I get that Leyden wants to be able to easily compare startup costs between itself and mainline, but what is this...

8331953: ubsan: metaspaceShared.cpp:1305:57: runtime error: applying non-zero offset 12849152 to null pointer

> We see now errors like this on Linux ppc64le with the patch added. > > ``` > # Internal Error (/jdk/src/hotspot/share/cds/metaspaceShared.cpp:1295), pid=7002, tid=7006 > # assert(is_aligned(base_address, base_address_alignment)) failed: >...

8332340: Add JavacBench as a test case for CDS

Thanks @liach @calvinccheung @matias9927 for the review /integrate

Enable clean PRs: fix various build configs, relax jcheck, etc

Looks good to me in general. Can you comment why the changes are needed in deoptimization.cpp?

Enable clean PRs: fix various build configs, relax jcheck, etc

> > Looks good to me in general. Can you comment why the changes are needed in deoptimization.cpp? > > Those are mostly moving the real counter code under `COMPILER2_OR_JVMCI`...

Shenandoah support

/sponsor

8312125: Refactor CDS enum class handling

Thanks @matias9927 @calvinccheung for the review /integrate