algos icon indicating copy to clipboard operation
algos copied to clipboard

Created BreadthFirstSearch.c

Open himanshusanecha opened this issue 5 years ago • 11 comments

Fixes #692

By submitting this pull request I confirm I've read and complied with the below declarations.

  • [x] I have read the Contribution guidelines and I am confident that my PR reflects them.
  • [x] I have followed the coding guidelines for this project.
  • [x] My code follows the skeleton code structure.
  • [x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • [x] This pull request will be closed if I fail to update it even once in a continuous-time span of 7 days.
  • [x] This pull request shall only be reviewed and merged once the Travis build passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • [x] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

himanshusanecha avatar Aug 29 '20 09:08 himanshusanecha

@himanshusanecha mention the issue it resolves Fixes #{ISSUE_NUMBER}

theyashshahs avatar Aug 29 '20 12:08 theyashshahs

Mentioned the issue number @yashshah2820

himanshusanecha avatar Aug 29 '20 12:08 himanshusanecha

@himanshusanecha post a GIF or a screenshot of the working of the code

theyashshahs avatar Aug 29 '20 12:08 theyashshahs

Screenshot (458)

himanshusanecha avatar Aug 29 '20 16:08 himanshusanecha

done @yashshah2820

himanshusanecha avatar Aug 29 '20 16:08 himanshusanecha

@himanshusanecha apply indentation so that the TRAVIS CI build is passed

theyashshahs avatar Aug 30 '20 06:08 theyashshahs

Sir @yashshah2820 applied indentation

himanshusanecha avatar Aug 30 '20 08:08 himanshusanecha

@yashshah2820 even after applying indentation code is not able to pass Travis CI can you look into the matter and guide me a bit about where i am wrong?

himanshusanecha avatar Aug 30 '20 08:08 himanshusanecha

@himanshusanecha I would recommend to add some , comments to briefly describe functions . The code Looks good to me :)

ishanksoni avatar Aug 31 '20 16:08 ishanksoni

@ishanksoni for sure sir and if possible guide me on how to pass travis CI test

himanshusanecha avatar Aug 31 '20 16:08 himanshusanecha

Hi, @himanshusanecha

You can see there is a .editorconfig in the root folder. This editorconfig file is used to tell how you should indent every file. We use this to have a specific format coding style.

And also don't take input from the user. I think your code is failing because of that.

You can check your PR checks here

AmanRaj1608 avatar Aug 31 '20 17:08 AmanRaj1608