igniterealtime
Use XMPP connection as local socks5 address
The default local address is often just "the first address found in the list of addresses read from the OS" and this might mean an internal IP address that cannot reach external servers. So wherever possible use the same IP address being used to connect to the XMPP server because this local address has a better chance of being suitable.
This MR adds the above behaviour, and two UTs to test that we use the local XMPP connection IP when connected, and the previous behaviour when not.
The default local address is often just "the first address found in the list of addresses read from the OS" and this might mean an internal IP address that cannot reach external servers. So wherever possible use the same IP address being used to connect to the XMPP server because this local address has a better chance of being suitable.
This MR adds the above behaviour, and two UTs to test that we use the local XMPP connection IP when connected, and the previous behaviour when not.
That is exactly what belongs in the commit message. Sadly the commit message right now does contain stuff that is just not true. ;)
OK done, should be good to merge now! Sorry I took so long to come make that whitespace change, coming back to assess your markups has been on the todo list a while! 😅
I just need to rebase this again quick...