igniterealtime
WIP Fix sending unnecessary broadcast cluster tasks to other nodes
Actually, I think there's a bigger issue with this.
From my reading, without this change the code sends a "Leave" presence message to every occupant of the room on every node. This can be in one of two cases;
a) If another node has left the cluster. In which case we only want to send to "local" users, or
b) org.jivesoftware.openfire.muc.spi.MultiUserChatServiceImpl#removeUser is invoked, e.g. because a Presence message of type ERROR is received. In which case, the notification needs to be sent to /every/ user, not just the ones on the local node where the message was received.
So you may need to somehow indicate which of the two cases you're dealing with, and treat accordingly.
@GregDThomas thanks for the review!
I see what you mean and will rework the pull request. This may take some time due to other work.
:wave: @cpetzka, do you still have interest in pushing this PR over the finish line?
👋 @cpetzka, do you still have interest in pushing this PR over the finish line?
I don't think so, as the file itself no longer exists and the MUC processing as a whole has been reworked.