cli icon indicating copy to clipboard operation
cli copied to clipboard

Add option in `config.yml` to easily change default staking denom

Open lumtis opened this issue 4 years ago • 3 comments

The current docs gives indication to modify the staking token denom: https://docs.starport.com/kb/genesis.html#change-values-in-modules

However, for many apps that use a single token for all module usages, different part of the genesis must be checked and modified

We should provide an option to easily modify these options in one place and set the "default token denom"

In config.yml

default-denom: "spn"

Would automatically set in the genesis:

genesis:
  app_state:
    staking:
      params:
        bond_denom: "spn"
    crisis:
      constant_fee:
        denom: "spn"
    gov:
      deposit_params:
        min_deposit:
          - "amount": "10000000"
            "denom": "spn"
    mint:
      params:
        mint_denom: "spn"

lumtis avatar Nov 19 '21 10:11 lumtis

Arguably, this looks more like a command, rather than a separate config. Perhaps,

starport chain config denom spn

Could modify config.yml in all the right places (and make necessary checks).

The thing I don't like about this being a separate config is that information can go out of sync (default-denom and configs in the genesis).

fadeev avatar Dec 27 '21 13:12 fadeev

Thanks problem solved was also facing same challenge. Can you assist with more commands to customise the config file eg . zero gas fees i.e send from coin wallet to wallet free with no transaction fee (is this possible?)

richmaskza avatar Jan 04 '23 14:01 richmaskza

Is that implemented guys? Kindly lemme know!

ahmadSaeedGoda avatar May 17 '24 05:05 ahmadSaeedGoda