ifme icon indicating copy to clipboard operation
ifme copied to clipboard

Implement react-autosuggest alternative

Open LMulvey opened this issue 3 years ago • 10 comments

Description

react-autosuggest is no longer maintained and has deprecated code that conflicts with our testing utilities, React Testing Library (@testing-library/react).

react-autosuggest still checks for event.keyCode, which is long since deprecated. testing-library/user-event stopped supporting as of v14 and now overwrites keyCode to 0 (only to support React's SyntheticEvents which expect a value for keyCode).

  • See: https://github.com/moroshko/react-autosuggest/blob/master/src/Autosuggest.js#L713
  • See: https://github.com/testing-library/user-event/issues/842

There are many alternatives out there but I would personally suggest downshift as it is well-maintained, well-supported, and quite scalable. The learning curve to get everything up-and-running can take a bit, but once you have your components established, it "just works". Plus, it has the benefit of being created and maintained by Kent C. Dodds, the creator/maintainer of React Testing Library.

Reproduction Steps

See #2166 discussion for more details

Screenshots


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

LMulvey avatar Oct 13 '22 05:10 LMulvey

Hi, sir @LMulvey can you please be more specific with this issue like what we have to do, and in what fields or components we have to replace the react-autosuggest with downshift? And I would love to work on this issue.

Thanks.

MuhammadAakash avatar Oct 22 '22 18:10 MuhammadAakash

Hey @MuhammadAakash, I haven't looked at https://github.com/downshift-js/downshift too deeply, but at first glance it looks like a good, maintained alternative to switch to. Feel free to take this on and investigate further!

julianguyen avatar Oct 25 '22 23:10 julianguyen

Hi @MuhammadAakash is there any progress on this issue? I'd love to work on it

pauluzo avatar Nov 19 '22 22:11 pauluzo

Hi @pauluzo. If you want to work just start working on it

MuhammadAakash avatar Nov 20 '22 03:11 MuhammadAakash

@pauluzo I have assigned this issue to you, feel free to reach out to us on slack if you have any query.

MuhammadAakash avatar Nov 20 '22 04:11 MuhammadAakash

@MuhammadAakash thanks. I'll reach out on slack.

pauluzo avatar Nov 20 '22 11:11 pauluzo

@julianguyen do you know of any progress that has been made on this?

lucas-codes-stuff avatar Feb 18 '24 20:02 lucas-codes-stuff

No progress @lucas-codes-stuff ! You can start from scratch here!

julianguyen avatar Feb 19 '24 19:02 julianguyen