clammit icon indicating copy to clipboard operation
clammit copied to clipboard

implement ssl-skip-verify to forward to self-signed-certificates

Open ghost opened this issue 4 years ago • 2 comments

we are using internally also SSL between our servers (nginx and Service fabric / load balancer) but these are self-signed-certiticates. Today clammit does not allow it

2021/11/04 23:18:04 Interceptor passed this request
2021/11/04 23:18:04 Forwarding to https://10.57.2.4:8001
2021/11/04 23:18:04 Failed to forward request: 'post' "https://10.57.2.4:8001/api/Files?api-version=1.0": x509: certificate signed by unknown authority

the PR allows to configure "ssl-skip-verify" (true, false).

If true, will skip SSL validation forwarding connection to use self-signed certitifates, default = false ssl-skip-verify = false

2021/11/04 23:22:26 Interceptor passed this request
2021/11/04 23:22:26 Forwarding to https://10.57.2.4:8001
2021/11/04 23:22:26 Request forwarded, response 200 OK
  • test cases ran
  • test cases implemented
  • documentation adapted
  • (some build documentation adapted)
  • GitHub build action run
  • build v0.7.3+ssl-skip-verify on our forked repository

ghost avatar Nov 05 '21 07:11 ghost

Any change on getting this merged?

butsjoh avatar Jan 12 '22 08:01 butsjoh

Also another question/observation: Why is it not possible that self signed certs that have been added to the os level are considered valid? I am not familiar with the go ecosystem but i would expect that a cert that is trusted on the system level would be working. We tried this together with https://github.com/maxsivkov/clammit-docker (and after adding the necessary cert files) and when we curl inside the container it works but when clammit forwards the request it keeps complaining about invalid cert.

butsjoh avatar Jan 12 '22 13:01 butsjoh