org-github-issues icon indicating copy to clipboard operation
org-github-issues copied to clipboard

Not finding assigned issues.

Open justinabrahms opened this issue 3 years ago • 12 comments

Hi there. I've had this working at some point, but something seems to be up b/c it's not working any longer. Not clear what, if anything, changed on my end.

Here's my config:

(use-package org-github-issues
  :straight (org-github-issues :host github :repo "iensu/org-github-issues")
  :defer t
  :config
  (setq org-github-issues-user "justinabrahms" ;; Specify Github user
        github-repositories '("ebay/goose") ;; My repositories
        org-github-issues-org-file "~/docs/github-issues.org" ;; My org file
        org-github-issues-tags '("github" "triage") ;; Always add these labels
        org-github-issues-auto-schedule "+0d" ;; Enable automatic scheduling
        org-github-issues-filter-by-assignee t ;; Enable filter by assignee
        org-github-issues-headline-prefix t) ;; Prefix all headlines with repository name

  ;; When idle for an hour loop over my projects and sync
  (mapcar (lambda (r)
            (run-with-idle-timer 3600 t (lambda () (org-github-issues-sync-issues r))))
          github-repositories))

When I do an M-x org-github-issues-sync-issues, it tells me:

No open issues found in repository https://github.com/ebay/goose

which is definitely not true.

I have validated my personal access token works just fine with

curl -H "Authorization: token my-personal-access-token-here" https://api.github.com/users/codertocat -I

I'd love any debugging steps you may have. Especially ones that expose raw api calls to the github web service.

justinabrahms avatar May 31 '22 20:05 justinabrahms

Hi! Sorry for the late response, I'll have a look at this in the coming days. You are still experiencing the issue right?

iensu avatar Jun 08 '22 09:06 iensu

Confirmed that I am still having this issue.

In case I fatfingered my authinfo file, this is the entry for this project

machine org-github-issues login justinabrahms password my-personal-access-token-here

It is located in ~/.authinfo, not ~/.authinfo.gpg and yes I know the security issue this represents.

justinabrahms avatar Jun 08 '22 13:06 justinabrahms

Hi again!

I believe I figured out the issues, can you please give it a try?

Apparently the filtering on assignee was made on the basis of org-github-issues-assignee which was initialized to user-login-name by default. I removed this arguably confusing default value and use org-github-issues-user for filtering if org-github-issues-assignee is not set explicitly.

iensu avatar Jul 01 '22 22:07 iensu

@iensu I'm somehow getting a new error.

Warning (comp): gh-common.el:101:14: Warning: reference to free variable ‘gh-object’ Disable showing Disable logging
Warning (comp): gh-common.el:113:3: Warning: reference to free variable ‘target’ Disable showing Disable logging
Warning (comp): /Users/jabrahms/.emacs.d/straight/build/gh/gh-common.el: Error: Symbol's function definition is void gh-marshal-default-spec Disable showing Disable logging

also in Messages:

command-execute: Symbol’s value as variable is void: ogi--issues-issue-list

justinabrahms avatar Jul 03 '22 00:07 justinabrahms

I'm on emacs 29.0.50 on osx, if it's relevant.

justinabrahms avatar Jul 03 '22 00:07 justinabrahms

@justinabrahms

I'm also running 29.0.50 on MacOS and while I do get the same compilation warnings, I don't get the last error. To me it sounds like the symbol ogi--issues-issue-list is being accessed as a variable and not a function and I can't find anyplace in the code where that is the case. ogi--issues-issue-list is only used once as a function.

You are still invoking it with M-x org-github-issues-sync-issues right?

I did a clean install removing both gh and org-github-issues and reinstalling them and it works for me. Could you maybe try running edebug and see where exactly it is you're hitting that error?

Sorry for the inconvenience!

iensu avatar Jul 03 '22 10:07 iensu

I'm invoking it w/ that command, yes.

I set an edebug on org-github-issues-sync-issues and ogi--fetch-issues. As I step through, I can't seem to step into "ogi--connect" b/c edebug says: Don’t know where ‘ogi--connect’ is defined

When step over it, I get this error: Symbol's value as variable is void: cl--nm

Looking through the source I have.. I don't see any mention of that at all.. so clearly I'm missing something.

I'm wondering if native compilation + eieio are not playing nicely together? Does that sound plausible? -justin

On Sun, Jul 3, 2022, at 3:46 AM, Jens Östlund wrote:

@justinabrahms https://github.com/justinabrahms

I'm also running 29.0.50 on MacOS and while I do get the same compilation warnings, I don't get the last error. To me it sounds like the symbol ogi--issues-issue-list is being accessed as a variable and not a function and I can't find anyplace in the code where that is the case. ogi--issues-issue-list is only used once as a function.

You are still invoking it with M-x org-github-issues-sync-issues right?

I did a clean install removing both gh and org-github-issues and reinstalling them and it works for me. Could you maybe try running edebug and see where exactly it is you're hitting that error?

Sorry for the inconvenience!

— Reply to this email directly, view it on GitHub https://github.com/iensu/org-github-issues/issues/15#issuecomment-1173057488, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA6DLVVNDUDYVCHMCXBIDVSFVSFANCNFSM5XOY7KOQ. You are receiving this because you were mentioned.Message ID: @.***>

justinabrahms avatar Jul 03 '22 18:07 justinabrahms

Might be... hm I don't know eieio that well at all to be honest. Will keep digging, but have not been able to reproduce the issue on my end yet.

iensu avatar Jul 05 '22 09:07 iensu

I'm invoking it w/ that command, yes.

I set an edebug on org-github-issues-sync-issues and ogi--fetch-issues. As I step through, I can't seem to step into "ogi--connect" b/c edebug says: Don’t know where ‘ogi--connect’ is defined

When step over it, I get this error: Symbol's value as variable is void: cl--nm

Looking through the source I have.. I don't see any mention of that at all.. so clearly I'm missing something.

I'm wondering if native compilation + eieio are not playing nicely together? Does that sound plausible? -justin

On Sun, Jul 3, 2022, at 3:46 AM, Jens Östlund wrote:

@justinabrahms https://github.com/justinabrahms

I'm also running 29.0.50 on MacOS and while I do get the same compilation warnings, I don't get the last error. To me it sounds like the symbol ogi--issues-issue-list is being accessed as a variable and not a function and I can't find anyplace in the code where that is the case. ogi--issues-issue-list is only used once as a function.

You are still invoking it with M-x org-github-issues-sync-issues right?

I did a clean install removing both gh and org-github-issues and reinstalling them and it works for me. Could you maybe try running edebug and see where exactly it is you're hitting that error?

Sorry for the inconvenience!

— Reply to this email directly, view it on GitHub https://github.com/iensu/org-github-issues/issues/15#issuecomment-1173057488, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA6DLVVNDUDYVCHMCXBIDVSFVSFANCNFSM5XOY7KOQ. You are receiving this because you were mentioned.Message ID: @.***>

justinabrahms avatar Oct 11 '22 07:10 justinabrahms

Hm.. do you have cl installed?

iensu avatar Oct 11 '22 09:10 iensu

I can't find any cl--nm symbol anywhere (C-h v and C-h f). Have you accidentally edited some file anywhere?

iensu avatar Oct 11 '22 09:10 iensu

Is it possible for you to try running this tool in a clean Emacs environment? emacs -Q and just load the necessary libraries. I have tried to reproduce the reported issue, but I'm not able to :(

iensu avatar Oct 12 '22 07:10 iensu