nacho.d.g comments

Results 139 comments of


                                            nacho.d.g

Improve contract loading in ping app tests

This should be imrpoved with https://github.com/freenet/freenet-core/pull/1716

Fix ignored ping tests with network topology constraints

No longer relevant, I believe, re-open otherwise

Potential Bug: `NetMessageV1::Unsubscribed` handler calls `subscribe` instead of removing the unsubscribing peer

@sanity after reading the code, I think we are definitively missing a call to `seeding_manager.prune_subscriber` after receiving the unsubscribe notification, and I don't think we need to call `subscribe`again, cause...

Potential Bug: `NetMessageV1::Unsubscribed` handler calls `subscribe` instead of removing the unsubscribing peer

@claude is this relevant anymore?

Ensure validate_state() is called after update_state() to enforce state validity and reduce redundant validation

Done

test_ping_partially_connected_network fails to connect to gateway nodes on CI

No longer relevant, I believe, re-open otherwise

Implement Retry Logic for Update Propagation

rebase on main

Bump arrayvec from 0.7.4 to 0.7.6

@dependabot rebase

chore(deps-dev): bump http-proxy-middleware from 2.0.6 to 2.0.9 in /tests/test-app-1

@dependabot recreate

chore(deps): bump bincode from 1.3.3 to 2.0.1

@dependabot rebase