react-spreadsheet
react-spreadsheet copied to clipboard
iddan
Fix Formula Evaluation
The second try of #214 Closes #63, #112
- [x] Create a point graph data structure
- [x] Create an engine that will use a graph and memoise computations
- [ ] Replace the current implementation of bindings and formula handling in the spreadsheet component
- [ ] Test the new point set methods
Pull Request Test Coverage Report for Build 4772252369
- 193 of 240 (80.42%) changed or added relevant lines in 14 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.6%) to 83.895%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/Cell.tsx | 2 | 3 | 66.67% |
| src/areModelsEqual.ts | 8 | 9 | 88.89% |
| src/formula.ts | 38 | 47 | 80.85% |
| src/point-graph.ts | 66 | 77 | 85.71% |
| src/engine.ts | 39 | 64 | 60.94% |
| <!-- | Total: | 193 | 240 |
| Totals | |
|---|---|
| Change from base Build 4362021332: | -0.6% |
| Covered Lines: | 1047 |
| Relevant Lines: | 1215 |
