react-spotify-api icon indicating copy to clipboard operation
react-spotify-api copied to clipboard

Update package.json

Open samjt opened this issue 6 years ago • 4 comments

I've realised that the inclusion of the @babel/plugin-transform-runtime wasn't actually enough, there needs to also be a dependency on @babel/runtime itself. I've added this as a dependency on for the library itself rather than a peerDep as I understand that it's supposed to be non-polluting.

I must have already had it installed from testing when I was proposing adding the plugin to .babelrc

See https://babeljs.io/docs/en/babel-plugin-transform-runtime#technical-details for information on why

samjt avatar May 15 '19 10:05 samjt

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   63.15%   63.15%           
=======================================
  Files          34       34           
  Lines         228      228           
  Branches       23       23           
=======================================
  Hits          144      144           
  Misses         76       76           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 739dddb...f159711. Read the comment docs.

codecov-io avatar May 15 '19 10:05 codecov-io

@samjt The build is failing. Can you try moving that to the devDependencies?

idanlo avatar May 21 '19 16:05 idanlo

@JB1905 The build is failing. Can you try moving that to the devDependencies?

Did you mean @samjt?

JB1905 avatar May 21 '19 16:05 JB1905

I've updated to devdep and it's passing now

samjt avatar May 28 '19 12:05 samjt