idaholab
XFEM stateful material property support
This adds a separate material property storage for XFEM cut elements, including properties connecting fragment pairs to formulate stateful material based constraints. Putting this up here to get some Civet testing going. This is continuing work on a three year old branch.
Closes #7291
Job Documentation on cfa8715 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Precheck on 2f8fcac wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/16891/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format b28b88dfcc3512ec6b067f428c14e805bcf28a1c
The design issue I'm facing now is that materials at extra QPs (e.g. along cuts) are executed by the material manager object and have to be compute = false. Now MOOSE is trying to be "helpful" by throwing a warning if a compute = false material does not override resetQpProperties... which almost none of the stock materials do.
I'm going to give this another look-through, but I think this is about ready to go. Since we've merged in a couple of other major XFEM changes, we should rebase and re-run the tests.
Job Generate and verify coverage on cfa8715 wanted to post the following:
Framework coverage
Coverage did not change
Modules coverage
Xfem
| 25abc3 | #16891 cfa871 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 81.69% | 81.23% | -0.46% | 73.84% | |
| Hits | 6285 | 6633 | +348 | 350 | |
| Misses | 1409 | 1533 | +124 | 124 | |
Full coverage reports
Reports
Warnings
-
xfemnew line coverage rate 73.84% is less than the suggested 90.0%
This comment will be updated on new commits.
@bwspenc and @jiangwen84 is this going anywhere? Do you need anything from me to advance this?
Yeah, @gambka just pointed me to this. I thought we had merged this, actually. I think maybe it just needed a little more documentation.
This pull request has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in 3 days if no further activity occurs. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dschwen This is really close, and I want this capability. It needs some documentation and the tests to be turned on. Let's talk about how to get this in. Maybe I can do the rest of it.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.