RefactoringEssentials
RefactoringEssentials copied to clipboard
Inconsistent RECS0082
public class QbCacheWriterTests : QbCacheTestsBase
{
private StoreWithQbItems store;
private QbCacheWriter CreateQbCacheWriter(DataStub store) // warns Parameter 'store' hides field 'store'
{
...
}
protected override IReadOnlyCollection<object> MakeDbSetMocks(DataStub store, dynamic settings = null) // no warning
{
...
}
}
Current implementation ignore public, protected, abstract and override methods as well as constructors and expicit interface implementations. As for me it doesn't have a sense, maybe except abstract modifier, but i could probably miss something due to my low experience in C#.
So before fixing i would like someone more experienced to let me know which of these restrictions are really necessary and which can be removed.