mantine-datatable icon indicating copy to clipboard operation
mantine-datatable copied to clipboard

drag and drop with @hello-pangea/dnd

Open mehdiraized opened this issue 2 years ago • 6 comments

mantine has sample for drag and drop rows in table but we need access to row render for use this package and add this feature https://ui.mantine.dev/category/dnd/

image

mehdiraized avatar Jan 17 '24 10:01 mehdiraized

Other users requested the feature too but no one came up with a valid PR so far, and I'm afraid I don't have the luxury of free time at the moment.

So, I'm 💯 percent open to a PR regarding this!

icflorescu avatar Jan 20 '24 15:01 icflorescu

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

MohdAhmad1 avatar Jul 04 '24 18:07 MohdAhmad1

I'm really curious to see other people's feedback on the PR addressing this issue. My primary concern in regarding the addition of a new mandatory dependency (Pangea DnD).

icflorescu avatar Jul 10 '24 15:07 icflorescu

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

can you change your code and create a new page in Examples, if you want to use the Pangea DnD, you can install the package and put the sample code on that page.

mehdiraized avatar Jul 11 '24 08:07 mehdiraized

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

can you change your code and create a new page in Examples, if you want to use the Pangea DnD, you can install the package and put the sample code on that page.

I have already added an example page in /examples/row-dragging/

MohdAhmad1 avatar Jul 11 '24 15:07 MohdAhmad1

i fixed this issue on this commit https://github.com/icflorescu/mantine-datatable/pull/621/commits/ee6b61bfb3ac8221b190078ebf4eee808e48312f

mehdiraized avatar Jul 14 '24 17:07 mehdiraized

@icflorescu can you check that PR ? everything is ok in this PR please check that

mehdiraized avatar Jul 29 '24 12:07 mehdiraized

Thanks for the outstanding work, release is on its way to npm registry!

icflorescu avatar Jul 30 '24 09:07 icflorescu