pisa icon indicating copy to clipboard operation
pisa copied to clipboard

make_asymmetry_plot needs generalising

Open steven-j-wren opened this issue 9 years ago • 2 comments

List of things needed:

  • Currently only handles 5-stage PISA (pid separate from reco) and event-by-event with the combine stage properly. This should be fixed.
  • Currently assumes two PID definition: 'trck' and 'cscd' regardless of the way they are split. Again, this should be fixed, but probably can't until the PID binning becomes more fleshed out.

Probably needs some more stuff too so feel free to bug me about it.

steven-j-wren avatar Oct 16 '16 21:10 steven-j-wren

Created issue #248 which, if that is fixed (ideas there implemented), should resolve the issue with a pipeline with PID stage behaving fundamentally differently (returning one map per PID spec) from reco with pid as binning dimension.

jllanfranchi avatar Nov 30 '16 19:11 jllanfranchi

I think this functionality can be merged (or already exists) in scripts/compare.py... for this, refer to issue #319

jllanfranchi avatar Mar 30 '17 02:03 jllanfranchi

The make_asymmetry_plots.py script has been removed and we have other more general issues replacing this one. Closing.

thehrh avatar Sep 10 '24 14:09 thehrh