react-simple-tree-menu icon indicating copy to clipboard operation
react-simple-tree-menu copied to clipboard
verified publisher icon iannbing

Key with '/' causing issues

Open tagyoureit opened this issue 5 years ago • 3 comments

I have come across a situation in some of my data where a key has the / character in it. I want to dig into this further but it seems like this could be a blocker with the current code.
EG:

{ parent: 'Furniture|Bookcases|Bush', 
    label: 'Bush Andora Bookcase, Maple/Graphite Gray Finish', 
    key: 'Furniture|Bookcases|Bush|Bush Andora Bookcase, Maple/Graphite Gray Finish', 
   }

Any thoughts or recommendations for how to work around this?

tagyoureit avatar Apr 09 '20 22:04 tagyoureit

Indeed it's not possible with the current implementation. One solution can be create an optional prop keySeparator with the default value "/". Should be very simple and straightforward. PR welcome 😉

iannbing avatar Apr 10 '20 19:04 iannbing

@PRGfx thanks for working on this!

@iannbing It looks like everything is here for the PR to be merged. Is it possible to complete this pull request?

tagyoureit avatar Jul 26 '22 15:07 tagyoureit

@iannbing, is it possible to merge this PR?

alinoil avatar Nov 29 '23 13:11 alinoil