ngDfp

ngDfp copied to clipboard

ng-dfp-ad-hide-when-empty and data-ng-dfp-ad-container doesn't work with Firefox (42.0)

1

When the ad is empty, the container doesn't hide.

anthol3g33k

how to use it with angular 2 ?

2

i would ask if i can use this library for angular 2 i need it so bad !

OdaiTu

I'm looking for a maintainer for this project, since I don't have time to keep up with issues and to keep this up to date.

ianmurrays

Works with localhost?

4

Not sure if it's an issue on my side or issue on google's side or if anyone else had this problem. Does dfp generally work when you are on localhost?...

mihaisavezi

Not an issue as such but a feature add

1

Firstly this project has been a life saver for me so thank you. My issue has been and this could be because of my shady Angular experience but when defining...

twistedcauldron

how to set PageTargeting() dynamically

2

DoubleClickProvider.defineSlot('/530209488/Parties_1', [300, 100], 'div-gpt-ad-1470051144620-0') .defineSlot('/530209488/Parties_2', [300, 100], 'div-gpt-ad-1470051144620-1') .defineSlot('/530209488/Parties_3', [300, 100], 'div-gpt-ad-1470051144620-2'); DoubleClickProvider.setPageTargeting('city',localStorage.getItem('DFTcity')); on changing the localStorage city value, the pageTargeting is not changing dynamically . it is effecting after...

krishnareddy226

Fix Readme

1

remove data- prefix from ng-dfp-ad in one example

westonganger

Can you add documentation in the readme as to how slot targeting works?

LorneCurrie

open link in other brower

5

I want to open the link that is vinculate in DFP ad, but it's opening in the app and I can't to back to the app

appscarvajal

I want to use defineOutOfPageSlot function for pageskin ads but i can't see its in your code. Can you add this feature? anyone help me?

kenanyildiz