githubot icon indicating copy to clipboard operation
githubot copied to clipboard
verified publisher icon iangreenleaf

Enable connecting to GitHub Enterprise with a self signed cert.

Open cwest opened this issue 11 years ago • 5 comments

Use environment variable HUBOT_GITHUB_SELF_SIGNED_CERT. Set to false by default.

cwest avatar May 06 '14 00:05 cwest

Cool! Would you mind taking a shot at writing a test for this? Not sure what exactly nock offers in this department, but hopefully we can figure something out.

iangreenleaf avatar May 06 '14 00:05 iangreenleaf

Note: This relies on https://github.com/technoweenie/node-scoped-http-client/pull/24.

cwest avatar May 06 '14 01:05 cwest

I'll take a stab at some tests tomorrow. :sunrise: Remember, it relies on an unpublished version of scoped-http-client which hasn't been updated in about five months, so I'm a little worried about this.

I did test this with my hubot setup so I know it works as expected as long as the two PRs are both present. :smile:

cwest avatar May 06 '14 01:05 cwest

Sounds good. That project has gone pretty quiet, though @technoweenie was still responsive the last time I needed to patch something upstream.

iangreenleaf avatar May 06 '14 03:05 iangreenleaf

It looks like the passthrough rejectUnauthorized option will work on the node-scoped-http-client side should work without any changes. So this PR should be able to progress.

davekonopka avatar May 09 '14 17:05 davekonopka