devnet_marathon_endgame icon indicating copy to clipboard operation
devnet_marathon_endgame copied to clipboard

dequote if_fullname if_shortname

Open bortok opened this issue 4 years ago • 0 comments

Hi,

When generating a topology with eOS devices, I noticed links between two eOS boxes would always get duplicated. The issue is caused by eOS returning LLDP neighbor's interface name in double-quotes. It should be safe to always dequote interface names as part of if_fullname and if_shortname functions. The fix was tested in on a simple 4-node spine-leaf topology.

Here is an example of show lldp neighbor details output from eOS:

Interface Ethernet1 detected 1 LLDP neighbors:

  Neighbor 2a19.9ed4.b06c/"Ethernet1", age 28 seconds
  Discovered 1:00:27 ago; Last changed 1:00:27 ago
  - Chassis ID type: MAC address (4)
    Chassis ID     : 2a19.9ed4.b06c
  - Port ID type: Interface name(5)
    Port ID     : "Ethernet1"
  - Time To Live: 120 seconds
  - System Name: "pod1"
  - System Capabilities : Bridge, Router
    Enabled Capabilities: Bridge, Router
  - Management Address Subtype: IPv4
    Management Address        : 10.0.254.254
    Interface Number Subtype  : ifIndex (2)
    Interface Number          : 5000000
    OID String                :
  - IEEE802.1 Port VLAN ID: 0
  - IEEE802.1/IEEE802.3 Link Aggregation
    Link Aggregation Status: Capable, Disabled (0x01)
    Port ID                : 0
  - IEEE802.3 Maximum Frame Size: 9236 bytes

bortok avatar Nov 17 '21 05:11 bortok