Tor.framework icon indicating copy to clipboard operation
Tor.framework copied to clipboard

Request to add via SwiftUI package manager

Open BenGWeeks opened this issue 2 years ago • 9 comments

Ability to simply add via the swift package manager would be awesome.

Anyone able to give some advice on steps to manually add this framework into a SwiftUI project (actually a Nostr client, Damus).

BenGWeeks avatar Apr 24 '23 21:04 BenGWeeks

I can definitely help with that! Not the package itself but getting it running on Damus.

Fonta1n3 avatar Apr 24 '23 22:04 Fonta1n3

That would be awesome thanks @Fonta1n3.

This is the progress so far:

https://github.com/BenGWeeks/damus/tree/tor-support

Let me know if you you would like contribute access!

Will be submitting this as a PR.

BenGWeeks avatar Apr 25 '23 09:04 BenGWeeks

That would be awesome thanks @Fonta1n3.

This is the progress so far:

https://github.com/BenGWeeks/damus/tree/tor-support

Let me know if you you would like contribute access!

Will be submitting this as a PR.

Hey for sure, I would love to contribute. No guarantees but I will try.

Fonta1n3 avatar Apr 29 '23 02:04 Fonta1n3

Invited!

BenGWeeks avatar Apr 29 '23 13:04 BenGWeeks

Interesting. Are you going to create a PR? Let me know how this goes. I always thought SPM is only for Swift stuff, but that ssems to be uninformed/outdated?

tladesignz avatar Apr 29 '23 20:04 tladesignz

Interesting. Are you going to create a PR? Let me know how this goes. I always thought SPM is only for Swift stuff, but that ssems to be uninformed/outdated?

I've only started SwiftUI development since December or so my knowledge is limited.

Yes, the iCepa/Tor.framework project can be made compatible with Swift Package Manager, even if it is not a pure Swift project. Swift Package Manager can handle projects with mixed-language sources, such as Objective-C and Swift, as long as the appropriate configurations are in place.

Yes, I think I may have a go at submitted a PR to add Swift Package Manager to this repo if desirable. I assume others would find it useful.

BenGWeeks avatar May 05 '23 01:05 BenGWeeks

Related: https://github.com/daltoniam/Starscream/issues/971

BenGWeeks avatar May 28 '23 02:05 BenGWeeks

It looks like creating the Swift Packager Manager would probably require more knowledgeable people of the framework due to package dependencies. Any plans to implement this? Would make it a lot easier to integrate into XCode projects I believe.

BenGWeeks avatar May 28 '23 11:05 BenGWeeks

Package dependencies? The only dependencies here are Tor itself, which is written in C. (Along with some dependencies it has: libevent, OpenSSL, xz and some system-provided libraries.)

Does SPM support Git submodules and calling shell build scripts? If not, this is doomed to fail.

tladesignz avatar May 31 '23 08:05 tladesignz