hypertrons-crx icon indicating copy to clipboard operation
hypertrons-crx copied to clipboard

[Feature] combine some features in the setting options

Open wxharry opened this issue 2 years ago • 1 comments

Also, I think perceptor-layout, perceptor-tab, and repo-networks can be combined into one option. The Perceptor button at the top is still displayed when the perceptor-layout and repo-networks options are not selected, however perceptor-tab option works well. image

Originally posted by @lhbvvvvv in https://github.com/hypertrons/hypertrons-crx/issues/659#issuecomment-1548124307

wxharry avatar May 17 '23 19:05 wxharry

Here is a possible quick solution to fix this:

  1. modify the index file for importing all features. Separate layout elements like perceptor tab and perceptor layout with other charts and tags.
  2. improve the file parser in the loader to get only the features that are not related to layout

In the above solution, we think of all features on the same level and to ignore those strucuture related features in the options is feasible.

However, the layout is more like a upper layer for the charts in that layout. So, it could be better we could reflect that relationship, which means if a user blocks the layout, all the elements inside that layout will be automatically disabled. Or, if one element can be enabled only if all its layout elements are enabled. Further researches and discussions are needed for the advanced solution.

wxharry avatar May 23 '23 01:05 wxharry