hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

Cartesian bar

Open anandtiwary opened this issue 2 years ago • 2 comments

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

anandtiwary avatar Dec 05 '23 07:12 anandtiwary

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (cf7c36a) 81.74% compared to head (c0503ae) 70.80%.

Files Patch % Lines
...mponents/cartesian/d3/data/series/cartesian-bar.ts 13.04% 59 Missing and 1 partial :warning:
...d/components/cartesian/d3/chart/cartesian-chart.ts 18.18% 8 Missing and 1 partial :warning:
...red/components/cartesian/d3/axis/cartesian-axis.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2562       +/-   ##
===========================================
- Coverage   81.74%   70.80%   -10.95%     
===========================================
  Files         929      930        +1     
  Lines       20854    20932       +78     
  Branches     3152     3162       +10     
===========================================
- Hits        17048    14820     -2228     
- Misses       3665     5855     +2190     
- Partials      141      257      +116     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 05 '23 07:12 codecov[bot]

Test Results

    4 files  ±0    317 suites  ±0   33m 8s :stopwatch: +36s 1 143 tests ±0  1 142 :white_check_mark:  - 1  0 :zzz: ±0  1 :x: +1  1 153 runs  ±0  1 152 :white_check_mark:  - 1  0 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit c0503aed. ± Comparison against base commit cf7c36a3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Dec 05 '23 07:12 github-actions[bot]