hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

fix: topology edge rendering with update pattern

Open itssharmasandeep opened this issue 2 years ago • 3 comments

itssharmasandeep avatar Jun 07 '23 20:06 itssharmasandeep

Unit Test Results

       4 files  ±0     306 suites  ±0   45m 55s :stopwatch: + 3m 1s 1 110 tests ±0  1 100 :heavy_check_mark:  - 10  0 :zzz: ±0  10 :x: +10  1 120 runs  ±0  1 110 :heavy_check_mark:  - 10  0 :zzz: ±0  10 :x: +10 

For more details on these failures, see this check.

Results for commit 6ca64da5. ± Comparison against base commit bd644305.

github-actions[bot] avatar Jun 07 '23 21:06 github-actions[bot]

Codecov Report

Merging #2249 (6ca64da) into main (bd64430) will decrease coverage by 25.63%. The diff coverage is 2.40%.

@@             Coverage Diff             @@
##             main    #2249       +/-   ##
===========================================
- Coverage   82.82%   57.20%   -25.63%     
===========================================
  Files         911      911               
  Lines       20004    20055       +51     
  Branches     3102     3113       +11     
===========================================
- Hits        16569    11473     -5096     
- Misses       3317     8218     +4901     
- Partials      118      364      +246     
Impacted Files Coverage Δ
.../edge/curved/entity-edge-curve-renderer.service.ts 7.14% <0.00%> (-92.86%) :arrow_down:
...y/renderers/edge/topology-edge-renderer.service.ts 6.25% <3.84%> (-73.38%) :arrow_down:
...y/src/shared/components/topology/d3/d3-topology.ts 9.73% <7.69%> (-79.36%) :arrow_down:

... and 206 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 07 '23 21:06 codecov[bot]

@itssharmasandeep can we close this PR?

anandtiwary avatar Jun 13 '23 00:06 anandtiwary