replace imaginary with kingfisher library

Open naveedmcs opened this issue 3 years ago • 3 comments

for performance improvements of loading images . I want to replace imaginary library to kingfisher library. what is possible solutions?

Feb 14 '22 09:02 naveedmcs

It looks like PR #283 switched image loading libraries.

That said I'd like to suggest that Lightbox be refactored in a way that allows developers to choose their own image loading library rather than forcing dependencies. For example I don't use SDWebImage or Kingfisher and instead use Nuke.

Feb 19 '22 19:02 chickdan

@chickdan Thanks for reply. how can i use this PR in my project? Please guide me. i will be very Thank full to you.

Feb 21 '22 07:02 naveedmcs

@chickdan Dependency injection is what we need here. and I seriously second this.

Feb 21 '22 23:02 mohpor