web3j icon indicating copy to clipboard operation
web3j copied to clipboard

Support public key recovery for EIP-155 transactions

Open jprudent opened this issue 2 years ago • 1 comments

What does this PR do?

It supports recovery of public keys when the transaction use the anti replay protection (EIP 155)

Where should the reviewer start?

PR is quite short

Why is it needed?

Most of txs are protected with EIP 155

jprudent avatar Oct 31 '23 16:10 jprudent

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 69.20%. Comparing base (9ee5b4f) to head (89e5032). Report is 45 commits behind head on master.

Files Patch % Lines
utils/src/main/java/org/web3j/commons/ChainId.java 0.00% 3 Missing :warning:
crypto/src/main/java/org/web3j/crypto/Sign.java 80.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1977      +/-   ##
============================================
+ Coverage     68.45%   69.20%   +0.75%     
- Complexity     3005     3117     +112     
============================================
  Files           488      493       +5     
  Lines         12568    13091     +523     
  Branches       1643     1691      +48     
============================================
+ Hits           8603     9060     +457     
- Misses         3485     3540      +55     
- Partials        480      491      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 13 '24 06:03 codecov[bot]