hyperledger
Fix multisignature
After the merge of #2582 we will broke multisignature mechanism. It was working because of signature checking mistake (see #2580).
The perfect fix we are thinking of is to allow users to use WASM smartcontract validators to check transactions. That requires things such as:
- WASM validators
- Second queue for multisig transactions
Second queue for multisig transactions
But how we will decide which transaction is multisig?
Also it's worth noticing that our Queue is broken in terms of multisigs.
Problem is the following:
We have method check_tx which treats false result of signature check as error and does not allow to add such signatures into the queue.
Mutisig transactions that does not received enough signatures would return false (because such transaction is not complete).
Simplest solution for such problem would be to allow putting transaction into the queue without signature_check (or at ) and pop from the queue transactions that pass `signature_check.
Problem with such approach is that malicious actor can flood queue with invalid transactions.
After meeting with @Arjentix we have two possible solutions for the problem:
-
Revert to initial approach where we allow to put transaction into the queue even if it not yet pass signature check condition. Some pros and cons of the first approach: +) Simple and straightforward to implement; +) Using isi for signature check is more transparent then wasm; -) Such approach could suffer from flooding of transactions that don't pass signature check (they will stay in the queue untill expired).
-
Introduce 3 variant (Allow, Deny, Pending) logic for signature check where we would reject to add transaction into the queue if it is signed incorrectly and allow to add transaction that still waits for more signatures. Some pros and cons of the second approach: +) More protected against flooding, because we can cut off some of invalid transactions, but malicious actor still can flood queue with transactions that are waiting for more transactions; +) Same advantage about transparency; -) Much harder to write signature check condition for 3 variant logic; -) Increasing size of
Valueeven further; -
For switching to WASM validators we are still considering all pros and cons.
As addition for method 1 and 2 second queue could be introduced, which will partially solve flooding problem, because transactions that are waiting for more signatures could be stored here. And transactions that pass signature check would be processed without any problem. However second queue still can reach it's full capacity.
