iroha icon indicating copy to clipboard operation
iroha copied to clipboard

[feature] #2158: Update `parity_scale_codec`

Open appetrosyan opened this issue 3 years ago • 4 comments

Signed-off-by: Aleksandr Petrosyan [email protected]

Description of the Change

Add changelog

appetrosyan avatar Aug 04 '22 09:08 appetrosyan

Codecov Report

Merging #2591 (ca89669) into iroha2-dev (a16d9c3) will decrease coverage by 1.80%. The diff coverage is 61.56%.

:exclamation: Current head ca89669 differs from pull request most recent head 88d0dfb. Consider uploading reports for the commit 88d0dfb to get more accurate results

@@              Coverage Diff               @@
##           iroha2-dev    #2591      +/-   ##
==============================================
- Coverage       67.61%   65.80%   -1.81%     
==============================================
  Files             140      155      +15     
  Lines           26173    28014    +1841     
==============================================
+ Hits            17696    18435     +739     
- Misses           8477     9579    +1102     
Impacted Files Coverage Δ
cli/derive/src/lib.rs 74.72% <ø> (ø)
cli/src/torii/mod.rs 28.88% <ø> (ø)
cli/src/torii/routing.rs 69.92% <0.00%> (-2.87%) :arrow_down:
client/src/client.rs 43.36% <0.00%> (-2.96%) :arrow_down:
client_cli/src/main.rs 0.26% <ø> (ø)
config/base/src/runtime_upgrades.rs 35.63% <ø> (ø)
core/src/block.rs 70.00% <ø> (ø)
core/src/queue.rs 95.67% <ø> (-0.08%) :arrow_down:
core/src/smartcontracts/isi/asset.rs 54.82% <ø> (ø)
core/src/smartcontracts/wasm.rs 95.39% <ø> (+0.12%) :arrow_up:
... and 146 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 04 '22 09:08 codecov[bot]

Please check older instances in changlelog: they were updated after generation, and now you are changing the phrasing back to the original. Since changelog usually requires some minor clean-up, I think it makes sense to generate changelog updates with commit hashes as parameters. This way you can specify which commits to include in this update and not alter the changelog for earlier releases

outoftardis avatar Aug 04 '22 09:08 outoftardis

Good point.

appetrosyan avatar Aug 04 '22 09:08 appetrosyan

PSA, this PR is to be squashed, and not rebased.

appetrosyan avatar Aug 07 '22 19:08 appetrosyan