identus-cloud-agent icon indicating copy to clipboard operation
identus-cloud-agent copied to clipboard

Update prism-node protobuffs

Open amagyar-iohk opened this issue 1 year ago • 2 comments

Is this a regression?

No

Description

Change the protos' package name inside prism-node from io.iohk.atala.prism.proto to org.hyperledger.identus.proto

Dir https://github.com/hyperledger/identus-cloud-agent/tree/main/prism-node/client/scala-client

Please provide the exception or error you saw


Please provide the environment you discovered this bug in


Anything else?

No response

amagyar-iohk avatar Dec 04 '24 12:12 amagyar-iohk

We have copies of the protobufs in a couple of locations. Does it make sense to normalize it to the library that can be used everywhere in the projects? I propose creating a public repository under input-output-hk with the protobufs and generating the corresponding libraries for Scala, TypeScript, Rust, and any other languages used in our projects. CC: @FabioPinheiro, @patextreme, @mineme0110.

yshyn-iohk avatar Jun 03 '25 08:06 yshyn-iohk

I think that is a generally good direction. A less ideal version having one copy per language is also fine IMO, but it shouldn't be mulitple copies per language spread everywhere.

patextreme avatar Jun 04 '25 05:06 patextreme