identus-cloud-agent icon indicating copy to clipboard operation
identus-cloud-agent copied to clipboard

The OOB's example in OOBPresentationInvitatio seems wrong

Open FabioPinheiro opened this issue 1 year ago • 3 comments

The OOB's example in OOBPresentationInvitatio doesn't seem align with the would be produce

https://github.com/hyperledger/identus-cloud-agent/blob/75b2736b71739be7c57c582f64b6845da9a6bd8c/cloud-agent/service/server/src/main/scala/org/hyperledger/identus/presentproof/controller/http/OOBPresentationInvitation.scala#L61

The json looks like

{
  "@id": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
  "@type": "https://didcomm.org/my-family/1.0/my-message-type",
  "did": "WgWxqztrNooG92RXvxSTWv",
  "imageUrl": "http://192.168.56.101/img/logo.jpg",
  "label": "Bob",
  "recipientKeys": [
    "H3C2AVvLMv6gmMNam3uVAjZpfkcJCwDwnZn6z3wXmqPV"
  ],
  "routingKeys": [
    "H3C2AVvLMv6gmMNam3uVAjZpfkcJCwDwnZn6z3wXmqPV"
  ],
  "serviceEndpoint": "http://192.168.56.101:8020"
}

FabioPinheiro avatar Aug 29 '24 09:08 FabioPinheiro

cc @mineme0110

FabioPinheiro avatar Aug 29 '24 09:08 FabioPinheiro

@FabioPinheiro that is old json DIDCOM v1 spec https://identity.foundation/didcomm-messaging/spec/ I think I will update the example encoded

mineme0110 avatar Aug 30 '24 10:08 mineme0110

FIX in this PR https://github.com/hyperledger/identus-cloud-agent/pull/1313

mineme0110 avatar Aug 30 '24 10:08 mineme0110

I will close and archive the issue. Thank you, @mineme0110 and @FabioPinheiro!

yshyn-iohk avatar Jun 09 '25 10:06 yshyn-iohk