firefly icon indicating copy to clipboard operation
firefly copied to clipboard
verified publisher icon hyperledger

Bug: newBranch created for E2E test failure with new namespace

Open aceppaluni opened this issue 8 months ago • 2 comments

Proposed changes

A new PR was created to resolve issues with test failures when adding a new namespace. This PR removes the setDefaults() function as it is not used in codebase.

Fixes #1545

Types of changes

  • [x] Bug fix
  • [ ] New feature added
  • [ ] Documentation Update

Please make sure to follow these points

  • [x] I have read the contributing guidelines.
  • [x] I have performed a self-review of my own code or work.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [x] My changes generates no new warnings.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)

Other Information

Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.

aceppaluni avatar May 22 '25 15:05 aceppaluni

@aceppaluni You have conflicts on the go.mod

EnriqueL8 avatar Jun 05 '25 11:06 EnriqueL8

I resolved the conflicts in mod :)

aceppaluni avatar Jun 05 '25 14:06 aceppaluni

Going to take this one over and clean it up

EnriqueL8 avatar Jul 02 '25 11:07 EnriqueL8

Another example of this failing https://github.com/hyperledger/firefly/actions/runs/14754031512/job/41417985010?pr=1674

EnriqueL8 avatar Jul 02 '25 13:07 EnriqueL8

See discussion in Discord for this one https://discord.com/channels/905194001349627914/1341066287530512444/1390652656178958487

EnriqueL8 avatar Jul 07 '25 09:07 EnriqueL8