firefly-cli icon indicating copy to clipboard operation
firefly-cli copied to clipboard

No ARM64 support

Open arturmartins opened this issue 1 year ago • 2 comments

I just learned that there is no ARM64 support: https://github.com/hyperledger/firefly-cli/blob/9c8b5dd279cb524a56f79d2b732fb399ee0cb541/internal/blockchain/fabric/fabric_provider.go#L621

It would be important to have a document explaining why. Furthermore, it would be greatly appreciated if there was an explanation of how it could be done locally (build your own images).

arturmartins avatar Jun 08 '24 17:06 arturmartins

I think it was the case that Fabric did not have ARM64 images but it seems that it has changed! https://lists.hyperledger.org/g/fabric/topic/96571575?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3A%2C%2C%2C0%2C0%2C0%2C96571575

This would be a great contribution to make, marking as good first issue 😃

EnriqueL8 avatar Jun 17 '24 11:06 EnriqueL8

For anyone looking at contributing a fix for this , I've just come across the same problem for Tessera in this PR https://github.com/hyperledger/firefly-cli/pull/315 and most of the hard work can be taken from that PR.

This is a great first issue for anyone to pick up!

EnriqueL8 avatar Jul 17 '24 13:07 EnriqueL8

@dwertent found out that actually the v1.3.1 FF already has bumped the version to 2.5 of Fabric which has an ARM64 image in DockerHub, so the issue is obsolete

EnriqueL8 avatar Aug 13 '24 17:08 EnriqueL8