BFT Block Puller: unit test the DeliveryRequester

Open tock-ibm opened this issue 2 years ago • 5 comments

add unit tests for the internal/pkg/peer/blocksprovider/delivery_requester.go against a real GRPC service, with security etc.

Dec 06 '23 13:12 tock-ibm

@tock-ibm I would like to work on this. Is someone working on this?

Apr 03 '24 04:04 solo-daemon

Also it seems that the file may have been moved to common/deliverclient/blocksprovider/delivery_requester.go

Apr 03 '24 05:04 solo-daemon

@solo-daemon Thanks for the contribution! I merged your unit tests PR, but see comments here: https://github.com/hyperledger/fabric/pull/4798#discussion_r1568722794

If you could address these comments in a new PR that would be great.

Apr 17 '24 13:04 tock-ibm

@tock-ibm sure I would add another pr shortly.

Apr 17 '24 13:04 solo-daemon

@tock-ibm I have added the suggested changes please take a look

Apr 24 '24 19:04 solo-daemon