caliper icon indicating copy to clipboard operation
caliper copied to clipboard

Transaction specification in benchmark file could be better

Open nklincoln opened this issue 5 years ago • 1 comments

Currently we define the transaction details (number of, or duration of) by:

{
  label: 'TestLabel0',
  txNumber: 60,
  rateControl: { },
  workload: {
    module: 'fabcar/createCar.js'
  }
}

it would be better to have:

{
  label: 'TestLabel0',
  transactionLoad : {
    type: duration | number,
    magnitude: number
  },  
  rateControl: { },
  workload: {
    module: 'fabcar/createCar.js'
  }
}

or as part of the workload definition itself

{
  label: 'TestLabel0',
  rateControl: { },
  workload: {
    module: 'fabcar/createCar.js'
    transaction: {
      type: duration | number,
      magnitude: number
  }
}

This would be of benefit if we ever moved into typings, since it is a more logical layout

nklincoln avatar Nov 19 '20 17:11 nklincoln

I absolutely support this! I like the middle version, it shows nicely that the concepts are orthogonal 👍

aklenik avatar Dec 01 '20 07:12 aklenik