cacti icon indicating copy to clipboard operation
cacti copied to clipboard

feat(satp-hermes): added cbdc ci

Open pandaio22 opened this issue 4 months ago • 2 comments

Pull Request Requirements

  • [X] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [X] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [X] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [X] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [X] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

pandaio22 avatar Sep 22 '25 11:09 pandaio22

Blocked by failing pipeline

RafaelAPB avatar Sep 22 '25 13:09 RafaelAPB

@pandaio22 please rebase so we can merge. @AndreAugusto11 can you please provide your review?

RafaelAPB avatar Oct 23 '25 22:10 RafaelAPB

@pandaio22 Hi, thanks for the PR. Just one comment from me based on the PR guidelines we follow, Can you make the title of PR as test(satp-hermes) or ci(satp-hermes) instead of feat, because adding a CI job is not a feature that users of Cacti might be concerned about. All the feat PRs gets mentioned in release notes but test or ci (and some more) gets skipped from release notes, hence this is a strong recommendation.

sandeepnRES avatar Nov 07 '25 10:11 sandeepnRES