cacti
cacti copied to clipboard
test: refactor jest test negative test cases - phase 1
Commit to be reviewed
test: refactor jest test negative test cases - phase 1
Primary Changes
---------------
1. Transformed negative jest test try-catch block into a more concise
version which points out exactly what was not matching assertions if
there is a failure
2. Modified invokeRawWeb3EthMethod to accommodate the test case which
has missing value for params
3. Tested the test cases which has code changes and confirmed they are
passing
Fixes: #3483
Pull Request Requirements
- [x] Rebased onto
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why. - [x] Have git sign off at the end of commit message to avoid being marked red. You can add
-sflag when usinggit commitcommand. You may refer to this link for more information. - [x] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
- [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
- [x] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.