cacti icon indicating copy to clipboard operation
cacti copied to clipboard

feat(recovery): add crash recovery implementation

Open Yogesh01000100 opened this issue 1 year ago • 4 comments

This PR addresses issue #3114

Changes

  • Crash Recovery: Updated crash_recovery.proto and related ts files; added core recovery logic (created functions not yet implemented).
  • Knex Config: Improved knexfile.ts and knexfile-remote.ts; added Docker Compose for production.

Yogesh01000100 avatar Aug 20 '24 21:08 Yogesh01000100

I will review this PR

RafaelAPB avatar Aug 21 '24 09:08 RafaelAPB

@Yogesh01000100 please rebase with satp-dev (should not have conflicts)

RafaelAPB avatar Aug 23 '24 13:08 RafaelAPB

@Yogesh01000100 please include documentation and tests, and update the description, as discussed.

RafaelAPB avatar Sep 02 '24 15:09 RafaelAPB

@Yogesh01000100 could you please squash the commits and rebase with latest version of satp-dev, prior to merge?

RafaelAPB avatar Sep 16 '24 20:09 RafaelAPB

Please include CrashStatus and LocalLog types in the open api spec and import them where needed

about this open API spec part as it has a tpl.json and a .json, which one to update I'm a bit unsure

Yogesh01000100 avatar Dec 15 '24 15:12 Yogesh01000100

Please include CrashStatus and LocalLog types in the open api spec and import them where needed

Is there any specific need for this to be in openapi ? i dont see it being used as any respone towards any API it's status tracker, and localLog type is okay in types, please clarify if there is any specific requirement to be in openapi? image

Yogesh01000100 avatar Dec 19 '24 18:12 Yogesh01000100

Added a commit fixing several issues. @Yogesh01000100 could you please take a look at the tests and double check everything works?

RafaelAPB avatar Jan 07 '25 15:01 RafaelAPB