cacti icon indicating copy to clipboard operation
cacti copied to clipboard

build(sync-ts-config): integrating the weaver packages to the monorepo build

Open ruzell22 opened this issue 1 year ago • 2 comments

Description

The sync-ts-config script has ignore paths that are weaver related for missing tsconfig.json file when executing yarn run sync-ts-config from the command line after having yarn run configure successfully on the main branch.

The 4 paths are: -/packages/cacti-plugin-weaver-driver-fabric/ -/weaver/common/protos-js/ -/weaver/samples/besu/simpleasset/ -/weaver/samples/besu/simplestate/

Related to: #3069

Acceptance Criteria

  1. Script in question runs fine after integrating of packages and removing the added ignore paths.

ruzell22 avatar Jun 28 '24 03:06 ruzell22

Hello @VRamakrishna , I would like to ask if there are tsconfig.json files for /common/protos-js, /samples/besu/simpleasset, and /samples/besu/simplestate that are not in that base folder but inside another folder? I am trying to do this solution https://github.com/hyperledger/cacti/pull/3367#issuecomment-2207777149 for them as well. I have tried it for /packages/cacti-plugin-weaver-driver-fabric and it worked when I ran the yarn run sync-ts-config without having it in ignore path. When I do it, however, a new path has missing tsconfig.json issue when running the script. /core/drivers/fabric-driver/

If there is no specific tsconfig.json file for the mentioned weaver related folders, is there something that I can do to resolve this issue? Thank you.

ruzell22 avatar Jul 09 '24 06:07 ruzell22

@ruzell22 Sorry, your query passed under my radar. The answer to your question is: no, if the respective folders don't contain a tsconfig.json file, it doesn't exist anywhere else. You are welcome to try and add it (though #3400 didn't really solve the issue) to the various Weaver modules, and we will review it.

VRamakrishna avatar Sep 04 '24 13:09 VRamakrishna