cacti icon indicating copy to clipboard operation
cacti copied to clipboard

build(plugin-keychain-memory-wasm): upgrade OpenAPI generator to v6.6.0

Open solo-daemon opened this issue 1 year ago • 6 comments

fix #2181 steps to reproduce :

cd packages packages/cactus-plugin-keychain-memory-wasm/ npm run generate-rust-server then make changes related to PrometheusExporterMetrics Also, the server expects Option<> type response on api calls but the generated code does not supports that so made changes to support that.

solo-daemon avatar May 12 '24 12:05 solo-daemon

Thankyou @solo-daemon for the pull request. Please let us know if you face any issue around this and when this PR can be reviewed for a possible merge. There are some other changes required related to the structure of the PR, the title, message and the commit message which can be updated once the PR is ready. Other than that, the diff is looking good at the moment !

TheJagpreet avatar May 14 '24 03:05 TheJagpreet

Hi @jagpreetsinghsasan actually at the time of making the PR the code i had not set up the dev container, inside the dev container some modification were required in the existing pr so, I am working on that

solo-daemon avatar May 14 '24 07:05 solo-daemon

@outSH @jagpreetsinghsasan this PR is ready for review now

solo-daemon avatar May 14 '24 11:05 solo-daemon

@solo-daemon It's fine for this for now, but for future pull requests please use only lowercase alphanumeric characters and dashes or underscores in the branch names. There are operating systems/software out there which gets people in trouble if their branch names are case sensitive in any way.

^^ This is not the actual review (yet) I just wanted to put it out there.

petermetz avatar May 17 '24 14:05 petermetz

@solo-daemon Are you still working on this? If not, no worries, I'm just doing some housecleaning and this is one of the oldest open pull requests.

petermetz avatar Jun 26 '24 20:06 petermetz

@petermetz i changed the commit message to match the pull request description, can you suggest any other changes once or any one's that i didin't got right.

solo-daemon avatar Jul 06 '24 05:07 solo-daemon

Closing this due to inactivity. Please feel free to re-open if you find the time to work on it later!

petermetz avatar Oct 03 '24 00:10 petermetz