besu icon indicating copy to clipboard operation
besu copied to clipboard

diffbased refactor

Open matkt opened this issue 2 years ago • 0 comments

Here's a breakdown of the PR:

  • Splitting Bonsai: The PR aims to divide Bonsai into two packages

  • Common Classes with a Prefix: The common part will include classes prefixed with "DiffBased." These classes are designed to provide a base for both Bonsai and any future storage format that might use this diff-based approach.

  • Bonsai's Specifics: Bonsai will retain its unique features in its own package. This means that while it shares the diff-based infrastructure with the common part, it also has its own specific functionalities that are not shared with other storage format.

  • Extension to Verkle: this modification add the possibility of adding "Verkle" as a new storage format based on the diff-based architecture. Like Bonsai, Verkle would use the common diff-based classes but also have its own specific features.

In summary, the pull request proposes restructuring Bonsai to make it more modular and efficient. This not only improves data management within Bonsai but also sets the stage for incorporating new format like Verkle, which can share the common base while having their unique functionalities.

Thanks for sending a pull request! Have you done the following?

  • [ ] Checked out our contribution guidelines?
  • [ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
  • [ ] Considered the changelog and included an update if required.
  • [ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • [ ] locally run all unit tests via: ./gradlew build
  • [ ] locally run all acceptance tests via: ./gradlew acceptanceTest
  • [ ] locally run all integration tests via: ./gradlew integrationTest
  • [ ] locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Fixed Issue(s)

matkt avatar Mar 13 '24 11:03 matkt