aries-framework-go-ext icon indicating copy to clipboard operation
aries-framework-go-ext copied to clipboard

chore(deps): Bump golang.org/x/crypto from 0.0.0-20210616213533-5ff15b29337e to 0.1.0 in /component/storage/mongodb

Open dependabot[bot] opened this issue 3 years ago • 0 comments

Bumps golang.org/x/crypto from 0.0.0-20210616213533-5ff15b29337e to 0.1.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Feb 25 '23 02:02 dependabot[bot]

Owww interesting. I didn't realise that vdrtools would filter out creds based on predicates. I don't believe other implementations do (acapy credx, AFJ anoncreds), worth checking what the "norm" is.

Some might argue that it is best to still return those credentials that fail the predicate, and have the consumer check the predicate themselves. I'd imagine in a UI this could let you do cool things, like show 5 credentials (returned from get creds for proof req), but visually grey out the creds that don't meet the predicate.

Not exactly sure if I have a strong opinion about this, just putting it out there that filtering by preds may not be "normal" behaviour based on other impls I've seen.

Similar case for filtering by revocation (I.e. don't return the credential if it cannot prove the non revocation interval), we currently don't do this (mostly Bcus it's very expensive). Acapy doesn't seem to do it either, but AFJ might (haven't deep dived this part of AFJ in awhile)

gmulhearn avatar Aug 29 '23 20:08 gmulhearn

That's some good points. I'll leave the issue open for any other discussion to spur out here

Patrik-Stas avatar Aug 29 '23 22:08 Patrik-Stas