aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

Add `proof_key` issuance option

Open PatStLouis opened this issue 1 year ago • 2 comments

Following the discussions in PR #2348, here's my suggestion to add an optional field to specify a verkey to use when querying the wallet for the didInfo used in issuing credentials.

This would satisfy the requirements raised by @Jsyro and some of the work we are doing around binding did:web to a did:indy.

Please review and share some toughts @dbluhm @swcurran @jamshale @ianco @TimoGlastra .

This will also preserve this enabling feature from the deprecated /jsonld/sign endpoint, giving controllers flexibility while using other did methods.

PatStLouis avatar May 27 '24 02:05 PatStLouis

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 28 '24 13:05 sonarqubecloud[bot]

As discussed in the ACA-PUG call today, we're looking at adding similar functionality by making it possible to tag keys with their verification method IDs. This was something we needed in #2959 as well. We will work with @PatStLouis to make sure the required interface changes can make it into ACA-Py regardless of the ultimate fate of #2959 (if needed, we can break them out of that PR and open it separately).

dbluhm avatar May 28 '24 17:05 dbluhm

@PatStLouis the DCv2 PR was just merged; I think there are some minor updates needed to make it so we can associate multiple kids with a key but otherwise the changes made their should support this use case. I propose we close this PR and create an issue to track that.

dbluhm avatar Jul 02 '24 16:07 dbluhm

Issue opened; @PatStLouis if there's good reason to have this PR open, feel free to reopen.

dbluhm avatar Jul 02 '24 16:07 dbluhm

@dbluhm that sounds good to me, thanks!

PatStLouis avatar Jul 02 '24 20:07 PatStLouis