aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

Wallet Database not Removed after Removing Wallet

Open PaulWen opened this issue 3 years ago • 2 comments

Current Behaviour

When calling POST /multitenancy/wallet/XXXXX/remove the wallet is being removed but the corresponding database still remains in the Postgres DB. When calling GET /multitenancy/wallets the wallet is not listed anymore.

Expected Behaviour

The wallet DB should be removed from Postgres when removing the wallet via the AcaPy HTTP API.

Setup

  • AcaPy started in Multitenancy Mode
  • Askar Wallet
    • the default database-per-wallet scheme is used
    • Postgres is used

PaulWen avatar Dec 05 '22 16:12 PaulWen

I also raised this topic in Discord (https://discord.com/channels/905194001349627914/1047175776228888698) and received the following hint from @andrewwhitehead:

It looks like the logic here might need to be updated to remove the database (Store) when multitenant_wallet_name is set https://github.com/hyperledger/aries-cloudagent-python/blob/e19cd6fe9f68407ddf640d7c90257270dfb63d40/aries_cloudagent/multitenant/askar_profile_manager.py#L87

PaulWen avatar Dec 05 '22 16:12 PaulWen

I have also tried this api and its not working as expected. Please change the code logic to delete wallet db from postgres also.

mohdhasnain123 avatar Jun 21 '24 09:06 mohdhasnain123