aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

key type registry

Open burdettadam opened this issue 3 years ago • 2 comments

This PR makes key types pluggable to enable plugins to define and register new ones.

Signed-off-by: Adam Burdett [email protected]

burdettadam avatar Sep 22 '22 23:09 burdettadam

Codecov Report

Merging #1957 (9437637) into main (a16347d) will decrease coverage by 0.01%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
- Coverage   93.55%   93.54%   -0.02%     
==========================================
  Files         539      539              
  Lines       34526    34529       +3     
==========================================
- Hits        32300    32299       -1     
- Misses       2226     2230       +4     

codecov-commenter avatar Sep 26 '22 18:09 codecov-commenter

@burdettadam can you catch this one up with the latest main branch? I get conflicts ...

ianco avatar Oct 20 '22 22:10 ianco

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 21 '22 16:10 sonarqubecloud[bot]

There are conflicts between this PR and PR #1955

It does indeed; we have a patch handy to cleanly merge the two after one or the other is merged but maybe we should just go ahead and put it in a single PR.

dbluhm avatar Oct 25 '22 14:10 dbluhm

We have a single PR now, #1986. Closing this one in favor of the new one.

burdettadam avatar Oct 25 '22 15:10 burdettadam