aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard

Webhook requests include a trailing slash

Open karimStekelenburg opened this issue 3 years ago • 1 comments

When providing a --webhook-url on startup, a trailing / seems to be added to the web hook requests. So if I provide https://example.example as the --webhook-url value, connection state changes are posted to https//example.example/topic/connections/ instead of https//example.example/topic/connections.

This deviates from what is documented here: https://github.com/hyperledger/aries-cloudagent-python/blob/main/AdminAPI.md#administration-api-webhooks.

Although this isn't a major issue, I know it caused some confusion here and there ;)

karimStekelenburg avatar Sep 12 '22 17:09 karimStekelenburg

Hey @ianco -- can you figure out what to do with this? I'm wondering if this started with an OpenShift issue? We definitely had a "trailing /" issue come up in OpenShift deployments at some point in the past -- John raised it years ago.

I don't really care about the answer (with or without "/"), but do want to have the code and docs consistent.

swcurran avatar Sep 14 '22 11:09 swcurran