h2 icon indicating copy to clipboard operation
h2 copied to clipboard

tone down debugs from codec modules

Open lthiery opened this issue 1 year ago • 3 comments

Some logging frameworks don't really tolerate module level configurations well. I have quite a broad project but h2 seems to be the only dependency that has such chatty debug settings.

Would you be open-minded to removing all debug! in favor of trace!?

lthiery avatar Nov 25 '24 17:11 lthiery

This library already has a lot of noise at the trace level, the things at debug level are indeed helpful for many people to debug without needing the full firehose.

I don't think the solution is to reduce the helpfulness of the logs for those people, but to use a logger that allows you to adjust specific libraries if you don't want their logs.

seanmonstar avatar Nov 25 '24 18:11 seanmonstar

I'm still trying to fix that but this is also the only crate that's causing so much chattiness. Perhaps if just the "send" in frame_write and "read" in frame_read could be downgraded?

lthiery avatar Nov 25 '24 19:11 lthiery

@seanmonstar checking in to see if this level of change would acceptable? the scope has been narrowed to only the messages that I believe are very chatty. I do agree that a logging system should be capable of tuning logs per module, but I also believe that debug logging should be a little less active than h2 is with these two instances.

Of course, up to you and will close and move on if you're not into it. Thanks for your work!

lthiery avatar Dec 12 '24 21:12 lthiery

Upvote :+1: It's too verbose.

vibornoff avatar Jul 11 '25 16:07 vibornoff

I still feel the same as my previous comment.

seanmonstar avatar Jul 11 '25 19:07 seanmonstar