Improve Led Device on/off and background effect
Summary
Fixes
- Queue LED-device switch off and on signals
- address LGTM findings
Update
- Do not switch-off LED-device, if background effect is configured an will kick-in soon
What kind of change does this PR introduce? (check at least one)
- [X] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Docs
- [ ] Build-related changes
- [ ] Other, please describe:
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
- [ ] Yes
- [X] No
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
- [ ] When resolving a specific issue, it's referenced in the PR's body (e.g.
Fixes: #xxx[,#xxx], where "xxx" is the issue number)
If adding a new feature, the PR's description includes:
- [ ] A convincing reason for adding this feature
- [ ] Related documents have been updated (docs/docs/en)
- [ ] Related tests have been updated
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
- [ ] Yes, CHANGELOG.md is also updated
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
@asturel Thx for sharing the issue and testing the fix.
Hello @Lord-Grey :wave:
I'm the Hyperion Project Bot and I want to thank you for contributing to Hyperion with your pull requests!
To help you and other users test your pull requests faster, I'll create a link for you to your workflow artifacts.
:link: https://github.com/hyperion-project/hyperion.ng/actions/runs/2776908342
Of course, if you make changes to your PR, I will create a new link.
Best regards, Hyperion Project
This pull request fixes 7 alerts when merging bde3b92954f983e4c93480e84ee80d36f3f4a421 into e17ce6cd4e24604f2a2818f12ecc1681306a797b - view on LGTM.com
fixed alerts:
- 6 for Useless regular-expression character escape
- 1 for DOM text reinterpreted as HTML