Ismayil Khayredinov comments

Results 92 comments of


                                            Ismayil Khayredinov

Deleting groups is not scalable

Sounds feasible. Perhaps the same column could help with draft/published state - what we do now (see blogs) is too hacky

Deleting groups is not scalable

I am proposing we stop doing this ridiculous clean up operation with all the evens fired and batch deletes. It's ok to trigger an event for entities, but all the...

ElggEntity::create() should throw exceptions

Not sure if that's BC. Classes extending type classes, might have implemented their ::create() methods relying on these checks done in ElggEntity

ElggEntity::create() should throw exceptions

Well, in this situation I was presented with an Exception that made no sense - it was related to malformated MySQL query (the guid was missing from the query). It...

ElggEntity::create() should throw exceptions

Adding to `HTTP Responses` milestone - once we add HTTP Exceptions we can decide how to catch it.

Consolidate "viewtype" and "format" concepts

I like it

Add more garbage collector rules

What happened to gargabecollector doing clean up of orphaned rows?

Add more garbage collector rules

There are still meta, annotations etc

labels that identify the position of deleted comments would help readability

IMO, it's impossible with the current implementation. Once wiped from database, there is no way of telling where there was a comment, or any other entity.

labels that identify the position of deleted comments would help readability

We could just change schema to add a deleted column.