husseycoding
Would you be able to shoot in a merge/pull here? https://github.com/OpenMage/magento-lts
Would you be able to shoot in a merge/pull here? https://github.com/OpenMage/magento-lts
Can do yes, but I'm not entirely sure the fix is still relevant for the most recent versions of Magento as I haven't tested it and I know the class in question has changed in the core since I created this module. Do you know that this is still broken?
I am not sure, as I also dont know what you changed/where
Maybe have a check here: https://www.diffchecker.com/Dxr5Cam1 (link online only today)
was diffed against: https://github.com/OpenMage/magento-lts/blob/1.9.3.1/app/code/core/Mage/SalesRule/Model/Validator.php
maybe check once and then final as I see others also would like to know: is this still a bug or not?
On Thu, Feb 9, 2017 at 11:23 AM, Jonathan Hussey [email protected] wrote:
Can do yes, but I'm not entirely sure the fix is still relevant for the most recent versions of Magento as I haven't tested it and I know the class in question has changed in the core since I created this module. Do you know that this is still broken?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/husseycoding/cartrulefix/issues/5#issuecomment-278602419, or mute the thread https://github.com/notifications/unsubscribe-auth/AAn0a846ZatmnDXWJcW0LG4dr-5f5Ng9ks5raukMgaJpZM4L75sX .
I would say the easiest way is to check whether functionality described in the bug report linked to from the module description is still broken in the latest version.