SwiftEntryKit icon indicating copy to clipboard operation
SwiftEntryKit copied to clipboard

[rotate] supportedInterfaceOrientations default value is .all

Open liamxujia opened this issue 5 years ago • 1 comments

Rotating the view to landscape would be a problem, and SwiftEntryKit would pop up portrait and rotate to landscape. I looked at the code, and I created EKRootViewController before EKWindow but when called rootViewController = rootVC EKRootViewController will be called supportedInterfaceOrientations lastAttributes for nil at this time, so this method returns the default value. The .portrait, now I modified to create supportedInterfaceOrientations returned. The default value is .all, namely screen pop-up view for the first time at this time there will be no problem

liamxujia avatar Oct 26 '20 07:10 liamxujia

Codecov Report

Merging #315 (12bb1a6) into master (cafba39) will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #315      +/-   ##
=========================================
- Coverage    2.04%   2.04%   -0.01%     
=========================================
  Files          96      96              
  Lines        5465    5473       +8     
=========================================
  Hits          112     112              
- Misses       5353    5361       +8     
Impacted Files Coverage Δ
Source/Infra/EKRootViewController.swift 0.00% <0.00%> (ø)
Source/Infra/EKWindowProvider.swift 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cafba39...12bb1a6. Read the comment docs.

codecov[bot] avatar Oct 26 '20 07:10 codecov[bot]