transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Add inputs_to_logits_ratio to LasrCTCConfig

Open kho opened this issue 2 months ago • 2 comments

What does this PR do?

This PR adds inputs_to_logits_ratio to LasrCTCConfig so that LasrForCTC can be used in an ASR pipeline with chunked decoding.

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [x] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

kho avatar Dec 08 '25 22:12 kho

@eustlb make fixup is not yet passing due to hop_length not being used in modelling code.

kho avatar Dec 08 '25 22:12 kho

Unfortunately this will break decoding with LM. Perhaps we should just hardcode hop_length to a fixed value for now in LasrFeatureExtractor?

kho avatar Dec 10 '25 18:12 kho

@eustlb I created https://github.com/huggingface/transformers/pull/42782 as a Plan B. What do you think?

kho avatar Dec 10 '25 19:12 kho

[For maintainers] Suggested jobs to run (before merge)

run-slow: lasr

github-actions[bot] avatar Dec 12 '25 13:12 github-actions[bot]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.